-
Notifications
You must be signed in to change notification settings - Fork 29
LBFGS Hess approx #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
johannahaffner
merged 158 commits into
patrick-kidger:dev
from
BalzaniEdoardo:hess_approx
Jul 14, 2025
Merged
LBFGS Hess approx #135
Changes from all commits
Commits
Show all changes
158 commits
Select commit
Hold shift + click to select a range
a8b3ffb
add a linear operator computing the descent update
BalzaniEdoardo 956329e
removed unused cls
BalzaniEdoardo 9380261
added update hessian state dict
BalzaniEdoardo 36a9d3c
partial applied to fn
BalzaniEdoardo 30669b4
allow pytree at set
BalzaniEdoardo c0be4bc
added fixes
BalzaniEdoardo 45a8f69
added import lbfgs
BalzaniEdoardo 925a73c
linted
BalzaniEdoardo f5e8bc5
improved varnames
BalzaniEdoardo f2aa7a6
linted
BalzaniEdoardo 3ccac0f
fixed docstrings
BalzaniEdoardo a5d16ef
revert unnecessary change
BalzaniEdoardo d29374e
do not use threshold
BalzaniEdoardo 5822ad5
improved comment
BalzaniEdoardo 3dbd061
removed todo
BalzaniEdoardo 689c876
use hist len attr
BalzaniEdoardo b5ba14d
renamed variable
BalzaniEdoardo d81fe10
remove unused linear solver
BalzaniEdoardo 090df71
test lbfgs linear op
BalzaniEdoardo 85fe537
remove jit
BalzaniEdoardo c0a09b9
added LBFGS to tests, added a test for the operator
BalzaniEdoardo b83db06
test pre-commit
BalzaniEdoardo 080afd2
test pre-commit 2
BalzaniEdoardo 60c9dee
lined
BalzaniEdoardo 3a8524b
started linting
BalzaniEdoardo 5956e33
linted test
BalzaniEdoardo d4e3624
changes for fixing pyright
BalzaniEdoardo 0660afc
add assertion to pass pyright
BalzaniEdoardo a1d5f17
fix typing
BalzaniEdoardo af7be91
forced commit adding back typevars
BalzaniEdoardo 5c375e8
fix output
BalzaniEdoardo 1c8f620
remove search from init args
BalzaniEdoardo 5543c15
hist len second to last
BalzaniEdoardo 13b2052
reflect arg order in docstrings
BalzaniEdoardo ab3a5d9
fix convergence
BalzaniEdoardo da41125
linted
BalzaniEdoardo 43fdd7f
fix var names
BalzaniEdoardo 677b84c
move state update into update
BalzaniEdoardo db3d0a9
add hessian update compute
BalzaniEdoardo ed555bf
test identity
BalzaniEdoardo 2e2d56c
test identity
BalzaniEdoardo b05fa4c
fix indexing
BalzaniEdoardo 96d6c89
added compact repr
BalzaniEdoardo be43422
fix linalg
BalzaniEdoardo 3ffedaf
removed debug code
BalzaniEdoardo 6a3add4
fix conversion in strict mode
BalzaniEdoardo 013b029
fix tests
BalzaniEdoardo 424bd51
fix roll_and_set comments
BalzaniEdoardo 33d35b0
lint
BalzaniEdoardo 9eaae6e
removed unused func
BalzaniEdoardo 9082f5e
fixed typing
BalzaniEdoardo f2c078e
removed verbose options
BalzaniEdoardo 442bbbd
removed verbose options
BalzaniEdoardo 4e967f5
improved docstrings
BalzaniEdoardo de6c15b
add test for warm-up state
BalzaniEdoardo 47bd5f6
warm-up state test fix
BalzaniEdoardo 84ad3f2
add multiple extra hist
BalzaniEdoardo b1f801e
add an assertion
BalzaniEdoardo 3a64a5b
renamed parameter back to inner_history
BalzaniEdoardo 7b74a86
add a linear operator computing the descent update
BalzaniEdoardo 8eb96c0
removed unused cls
BalzaniEdoardo 2788d2d
added update hessian state dict
BalzaniEdoardo ab816f1
partial applied to fn
BalzaniEdoardo 1f4e217
allow pytree at set
BalzaniEdoardo 1307644
added fixes
BalzaniEdoardo 2937fd6
added import lbfgs
BalzaniEdoardo a6b5bc1
linted
BalzaniEdoardo 4896842
improved varnames
BalzaniEdoardo 644b9ed
linted
BalzaniEdoardo b6a9a02
fixed docstrings
BalzaniEdoardo 0a50627
revert unnecessary change
BalzaniEdoardo 0239c68
do not use threshold
BalzaniEdoardo 6caf975
improved comment
BalzaniEdoardo 32c5d8b
removed todo
BalzaniEdoardo 92648ac
use hist len attr
BalzaniEdoardo 16e72ae
renamed variable
BalzaniEdoardo 263effa
remove unused linear solver
BalzaniEdoardo 8ae60c7
test lbfgs linear op
BalzaniEdoardo cdc9748
remove jit
BalzaniEdoardo 751a2ec
added LBFGS to tests, added a test for the operator
BalzaniEdoardo f5d9ebe
test pre-commit
BalzaniEdoardo 26154fe
test pre-commit 2
BalzaniEdoardo f44e79d
lined
BalzaniEdoardo 2db0b5a
started linting
BalzaniEdoardo 8ccf14e
linted test
BalzaniEdoardo ba84546
changes for fixing pyright
BalzaniEdoardo 6a753a8
add assertion to pass pyright
BalzaniEdoardo 0b1f018
fix typing
BalzaniEdoardo 25b6e4d
forced commit adding back typevars
BalzaniEdoardo a8e33ad
fix output
BalzaniEdoardo 353c85b
remove search from init args
BalzaniEdoardo 405df6c
hist len second to last
BalzaniEdoardo 87c2118
reflect arg order in docstrings
BalzaniEdoardo fe8922d
fix convergence
BalzaniEdoardo a80823f
linted
BalzaniEdoardo e746f3c
fix var names
BalzaniEdoardo 46e14b5
move state update into update
BalzaniEdoardo 921f5a3
add hessian update compute
BalzaniEdoardo 0721680
test identity
BalzaniEdoardo 3d7fe9d
test identity
BalzaniEdoardo cf551b4
fix indexing
BalzaniEdoardo 3a413c1
added compact repr
BalzaniEdoardo 89b6f73
fix linalg
BalzaniEdoardo 0d6e298
removed debug code
BalzaniEdoardo 7a0342d
fix conversion in strict mode
BalzaniEdoardo 7cc524c
fix tests
BalzaniEdoardo 1dac261
fix roll_and_set comments
BalzaniEdoardo 9764d54
lint
BalzaniEdoardo a845bb4
removed unused func
BalzaniEdoardo 8a712f4
fixed typing
BalzaniEdoardo 99d4a7e
removed verbose options
BalzaniEdoardo b5e77f1
removed verbose options
BalzaniEdoardo 552b74d
improved docstrings
BalzaniEdoardo 8eaf147
add test for warm-up state
BalzaniEdoardo 189b7aa
warm-up state test fix
BalzaniEdoardo 1ba895a
add multiple extra hist
BalzaniEdoardo 5cde2c7
add an assertion
BalzaniEdoardo c6e2aca
renamed parameter back to inner_history
BalzaniEdoardo ea10532
re-organising quasi-newton, pyright fixes and some simplifications
fab3658
ruff + pyupgrade after rebase on latest dev
adcdbcf
ruff + pyupgrade after rebase on latest dev
0058b73
re-organising quasi-newton, pyright fixes and some simplifications
c769268
rebase on dev, pyupgrade + fixes
093ce74
marking a To-Do for Johanna
8617111
typo fix: spurious
c5b8f66
small fixes
43320a0
split module and create separate file for L-BFGS, mark TODOs for PR c…
ef6f8b0
take operator test out of rotation for now (relies on private imports)
647ce42
tiny doc tweaks
411206c
simplify update
BalzaniEdoardo ad8d2f5
linted
BalzaniEdoardo be6853d
merged latest commits
BalzaniEdoardo 36ae69f
Merge pull request #1 from BalzaniEdoardo/simplify_update
BalzaniEdoardo 9d3e953
remove unused import
367ce4f
formatting fix
4c29f4a
cleaning the To-Dos
eb17414
double where trick addressed
BalzaniEdoardo 7a65e2e
use concatenate
BalzaniEdoardo 7da438d
document pyright: ignore in Quasi Newton
aabde0f
address pyright issues
836e48e
fix names and some doc tweaks
2e6cac0
addressed remaining issues: naming, better type hints.
2a8df02
small fixes
c6c46be
teeny tiny fix
6e76c03
move a comment
e466ced
implement .conj method (abstract in Lineax)
6d334b7
more small fixes
523cfed
add safe divide for inner and comment
BalzaniEdoardo 422f839
linted
BalzaniEdoardo 329bac5
Merge branch 'hess_approx' of github.com:BalzaniEdoardo/optimistix in…
BalzaniEdoardo 77dba7a
add as array
BalzaniEdoardo 6cf0725
add asarray
BalzaniEdoardo d724a4d
write the history length into the state
02a69b7
fix history length in L-BFGS special tst
a85bca4
reorder and improve documentation of inverse operator function + some…
e7a55b3
add comments explicating our strategy for Cholesky solves of partly f…
89bc63d
document hessian update state in quasi-Newton
bd09b85
document choice for computation of gamma
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,3 +10,5 @@ examples/data | |
.idea | ||
.venv | ||
.DS_Store | ||
.devcontainer | ||
.benchmarks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.