Runtime API: introduce candidates_pending_availability
#4027
Conversation
Signed-off-by: Andrei Sandu <[email protected]>
…reim/candidates_pending_availability
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
sandreim
added
T4-runtime_API
polkadot/zombienet_tests/async_backing/004-async-backing-6s.toml
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
|
|
||
| /***** Added in v11 *****/ | ||
| /// Elastic scaling support | ||
| #[api_version(11)] |
There was a problem hiding this comment.
is it fine to reuse the api version? haven't seen this before
There was a problem hiding this comment.
Yeah, it is per method. Check above version 7 which added async backing.
There was a problem hiding this comment.
I guess this can be done only if there wasn't a runtime release in the meantime (between the claimqueue API and this API). Otherwise, versioning doesn't really make sense if we can add more things in a past version
There was a problem hiding this comment.
Yes it is only for staging APIs
There was a problem hiding this comment.
Currently production is at 10: https://github.com/polkadot-fellows/runtimes/blob/main/relay/kusama/src/lib.rs#L2147
I'd prefer to conflate all of the current staging methods into a runtime api version release (11). After discussing with @tdimitrov it seems there are no strict rules, except not adding on top of an released to prod version.
@eskimor WDYT ?
There was a problem hiding this comment.
as discussed, sounds good. I thought the changes were already included in a testnet runtime release
Signed-off-by: Andrei Sandu <[email protected]>
…reim/candidates_pending_availability Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
…reim/candidates_pending_availability
Fixes #3576
Required by elastic scaling collators.
Deprecates old API:
candidate_pending_availability.TODO: