Try to fix bridges+zombienet tests when running in a merge queue #2940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
R0-no-crate-publish-required
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like some collision has happened here recently - while we've been adding new zombienet tests in this PR and some changes were introduced for the merge queues here. I've missed the latter PR and now our new tests are failing when started in a merge queue. Example: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines/434816 (job: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4925064).
We can't use the fix from #2502 directly, because we use
DOCKER_IMAGES_VERSION(akaCI_COMMIT_SHORT_SHAfor merge queue case) inimagename and (IIUC) it can't used shell variables from.before_script. So we need to use gitlab variables. I haven't found an easy way to change variable value, based on some conditions. The "hard" option is to userules::variables, which I've tried to use here.Don't know if there's a way to tests those changes, especially given that the problem appears only in a merge queue, so I'm kindly asking for @paritytech/ci help here - am I doing this right? Thank you!