Use serde-content instead of private serde types #1062
Merged
+91
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
commented
Sep 27, 2025
| let de: serde::__private::de::ContentRefDeserializer<D::Error> = | ||
| serde::__private::de::ContentRefDeserializer::new(&content); | ||
| let content = serde_content::Value::deserialize(deserializer)?; | ||
| let de = serde_content::Deserializer::new(content.clone()).coerce_numbers(); |
Member
Author
There was a problem hiding this comment.
This clone is theoretically cheap if the content contains borrowed data since serde_content::Value uses Cow internally.
mischnic
approved these changes
Sep 29, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1056
Uses the serde-content crate to buffer during deserialization instead of internal private serde types, which have now moved.