refactor(prune): remove receipts log filter segment #19184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-debt
CodSpeed Performance ReportMerging #19184 will not alter performanceComparing Summary
|
shekhirin
requested review from
Rjected,
gakonst,
joshieDo,
klkvr,
mattsse,
mediocregopher,
rakita and
rkrasiuk
as code owners
mattsse
approved these changes
Oct 22, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
all of this lgtm
pending @RomanHodulak
Comment on lines
+64
to
+66
| #[arg(long = "prune.receiptslogfilter", value_name = "FILTER_CONFIG", hide = true)] | ||
| #[deprecated] | ||
| pub receipts_log_filter: Option<String>, |
Collaborator
There was a problem hiding this comment.
should we just yeet this entirely?
Comment on lines
+163
to
+167
| if self.receipts_log_filter.is_some() { | ||
| tracing::warn!( | ||
| target: "reth::cli", | ||
| "The --prune.receiptslogfilter flag is deprecated and has no effect. It will be removed in a future release." | ||
| ); |
Collaborator
There was a problem hiding this comment.
ah I see we keep it for this warn message, makes sense
RomanHodulak
approved these changes
Oct 22, 2025
Collaborator
Author
|
@RomanHodulak oops, forgot to delete the file itself! Thanks. |
shekhirin
added a commit
that referenced
this pull request
Nov 11, 2025
This reverts commit b5df3f3.
shekhirin
added a commit
that referenced
this pull request
Nov 11, 2025
This reverts commit b5df3f3.
shekhirin
added a commit
that referenced
this pull request
Nov 11, 2025
This reverts commit b5df3f3.
shekhirin
added a commit
that referenced
this pull request
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18889