wip:feat: update chain on fcu unwind #17857
Draft
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #17798
just a smol comment re what would need to be done here in order to support this usecase that isn't allowed by the ethereum spec, but I'm unsure if we should even support unwinding the chain like this.
the intended use case for this was originally so that op can build an alternative chain based on a canonical ancestor block. the limitation with how we currently handle this is that this doesn't reset the node's LATEST state so until the new alternative block is applied the current head block remains the LATEST.
we effectively would need to do step 3 here as well, but this becomes slightly more difficult if a child block of the new head is already committed to disk
reth/crates/engine/tree/src/tree/mod.rs
Lines 876 to 893 in f3a3fff