feat(ecies): implement constant-time comparison for MAC verification #17825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the MAC verification in the ECIES implementation to use constant-time comparison to prevent timing attacks.
Background
The previous implementation used regular comparison operators (
!=
) for MAC tag verification. This could potentially cause the following issues:Implementation Details
hmac_sha256()
and verify with regular comparisonverify_hmac_sha256()
function with HMAC's built-inverify_slice()
method for constant-time comparisondigest()
and verify with regular comparisonverify()
method withsubtle::ConstantTimeEq::ct_eq()
for constant-time comparisonhmac
crate usessubtle
in a verification step as well