feat: relax EthereumAddons trait bounds to support generic validators #16816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to #16615 for OpAddOns, this relaxes the trait bounds on EthereumAddons to support custom engine validators and API builders. Also updates TestNode in exex test-utils to match the new generic structure. This allows downstream users to customize validators while reusing EthereumAddons.
mattsse
requested review from
Rjected,
gakonst,
onbjerg and
shekhirin
as code owners
The Flashbots validation API integration was accidentally removed during the refactoring. This commit restores it by: - Adding back the ValidationApi initialization in launch_add_ons - Adding required dependencies (reth-rpc-builder, reth-rpc-server-types) - Importing necessary traits and types
Contributor
|
awesome reduction in sdk LoC required berachain/bera-reth#7 |
PeaStew
pushed a commit
to NeuraProtocol/reth-new-consensus
that referenced
this pull request
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #16615 for OpAddOns, this relaxes the trait bounds on EthereumAddons to support custom engine validators and API builders. Also updates TestNode in exex test-utils to match the new generic structure.
Summary
This PR makes
EthereumAddonsmore flexible by:EthChainSpec + EthereumHardforksinstead of hardcodedChainSpecEthereumEngineValidatorBuildergeneric overChainSpecwith_engine_api()andwith_engine_validator()to allow customizationChanges
EthereumAddonsto have generic parameters<N, EthB, EV, EB>TestNodein exex test-utils to match the new structureThis allows downstream users to customize validators while reusing EthereumAddons, avoiding code duplication.
fyi @rezbera