Skip to content

chore: re-export all types in node mod #16710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025
Merged

chore: re-export all types in node mod #16710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/ethereum/node/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ pub use evm::{EthEvmConfig, EthExecutorProvider};

pub use reth_ethereum_consensus as consensus;
pub mod node;
Copy link
Collaborator

@RomanHodulak RomanHodulak Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe too much of a BC break, but since its re-exported, this should be private. Otherwise, there are two paths and its pretty confusing when trying to import something.

Suggested change
pub mod node;
mod node;

Copy link
Collaborator Author

@mattsse mattsse Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would break existing imports that is also used currently, so we can keep this pub for now

pub use node::{EthereumEthApiBuilder, EthereumNode};
pub use node::*;

pub mod payload;

Expand Down
2 changes: 1 addition & 1 deletion crates/optimism/node/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ pub use engine::OpEngineTypes;
pub use reth_optimism_payload_builder::{OpPayloadPrimitives, OpPayloadTypes};

pub mod node;
pub use node::{OpNetworkPrimitives, OpNode};
pub use node::*;

pub mod rpc;
pub use rpc::OpEngineApiBuilder;
Expand Down
Loading