Skip to content

Conversation

@Ayushdubey86
Copy link
Contributor

@Ayushdubey86 Ayushdubey86 commented May 15, 2025

Hey @mattsse , can you check this out once free , it resolves #16267

@farazdagi
Copy link
Contributor

I wish you had notified that you will work on this. Once assigned, I haven't looked into whether anybody submitted PRs for the issue, and now seems my (#16281) and yours PRs are almost the same. The only thing, it seems, is that I've imported alloy_primitives::Address instead of revm_primitives::Address (which effectively is the same thing).

@Ayushdubey86
Copy link
Contributor Author

I wish you had notified that you will work on this. Once assigned, I haven't looked into whether anybody submitted PRs for the issue, and now seems my (#16281) and yours PRs are almost the same. The only thing, it seems, is that I've imported alloy_primitives::Address instead of revm_primitives::Address (which effectively is the same thing).

Actually , I started working on this pr before it got assigned ,but yeah should have kept you in loop once it was raised! looks like your pr will be merged :)🥇

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closing as dup of #16281 to respect process

@mattsse mattsse closed this May 15, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Reth Tracker May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Change TxCustom to TxPayment

3 participants