Skip to content

chore: bump log GetPayload events to debug level #16196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

chore: bump log GetPayload events to debug level #16196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e600ed
bump log GetPayload events to debug level
kiflomte May 13, 2025
0791b20
update logs for engine trace
kiflomte May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/optimism/rpc/src/engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ use reth_rpc_api::IntoEngineApiRpcModule;
use reth_rpc_engine_api::EngineApi;
use reth_storage_api::{BlockReader, HeaderProvider, StateProviderFactory};
use reth_transaction_pool::TransactionPool;
use tracing::{info, trace};
use tracing::{debug, info, trace};

/// The list of all supported Engine capabilities available over the engine endpoint.
///
Expand Down Expand Up @@ -328,7 +328,7 @@ where
&self,
payload_id: PayloadId,
) -> RpcResult<EngineT::ExecutionPayloadEnvelopeV2> {
trace!(target: "rpc::engine", "Serving engine_getPayloadV2");
debug!(target: "rpc::engine", id = %payload_id, "Serving engine_getPayloadV2");
Ok(self.inner.get_payload_v2_metered(payload_id).await?)
}

Expand Down
4 changes: 2 additions & 2 deletions crates/payload/builder/src/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,14 +286,14 @@ where
id: PayloadId,
kind: PayloadKind,
) -> Option<PayloadFuture<T::BuiltPayload>> {
trace!(%id, "resolving payload job");
debug!(target: "payload_builder", %id, "resolving payload job");

let job = self.payload_jobs.iter().position(|(_, job_id)| *job_id == id)?;
let (fut, keep_alive) = self.payload_jobs[job].0.resolve_kind(kind);

if keep_alive == KeepPayloadJobAlive::No {
let (_, id) = self.payload_jobs.swap_remove(job);
trace!(%id, "terminated resolved job");
debug!(target: "payload_builder", %id, "terminated resolved job");
}

// Since the fees will not be known until the payload future is resolved / awaited, we wrap
Expand Down
4 changes: 2 additions & 2 deletions crates/rpc/rpc-engine-api/src/engine_api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ use reth_tasks::TaskSpawner;
use reth_transaction_pool::TransactionPool;
use std::{sync::Arc, time::Instant};
use tokio::sync::oneshot;
use tracing::{trace, warn};
use tracing::{debug, trace, warn};

/// The Engine API response sender.
pub type EngineApiSender<Ok> = oneshot::Sender<EngineApiResult<Ok>>;
Expand Down Expand Up @@ -977,7 +977,7 @@ where
&self,
payload_id: PayloadId,
) -> RpcResult<EngineT::ExecutionPayloadEnvelopeV2> {
trace!(target: "rpc::engine", "Serving engine_getPayloadV2");
debug!(target: "rpc::engine", id = %payload_id, "Serving engine_getPayloadV2");
Ok(self.get_payload_v2_metered(payload_id).await?)
}

Expand Down
Loading