perf: reuse accounts trie in payload processing #16181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
the
C-perf
Rjected
force-pushed
the
dan/keep-trie-around
branch
7 times, most recently
from
648cd41 to
5bd4e41
Compare
Rjected
force-pushed
the
dan/keep-trie-around
branch
from
5bd4e41 to
613ea79
Compare
Rjected
force-pushed
the
dan/keep-trie-around
branch
2 times, most recently
from
21b17c5 to
6043a1a
Compare
rkrasiuk
requested changes
May 23, 2025
crates/trie/sparse/src/trie.rs
Outdated
Comment on lines
73
to
78
| Blind { | ||
| /// This is an optional field that can be used to store a previously allocated | ||
| /// trie. In these cases, the trie will still be treated as blind, but the allocated trie | ||
| /// will be reused if the trie becomes revealed. | ||
| allocated: Option<Box<RevealedSparseTrie<P>>>, | ||
| }, |
Member
There was a problem hiding this comment.
let's get rid of this pls. maybe make it a separate variant? e.g. AllocatedEmpty
crates/trie/sparse/src/trie.rs
Outdated
| /// This is an optional field that can be used to store a previously allocated | ||
| /// trie. In these cases, the trie will still be treated as blind, but the allocated trie | ||
| /// will be reused if the trie becomes revealed. | ||
| allocated: Option<Box<RevealedSparseTrie<P>>>, |
Member
There was a problem hiding this comment.
it doesn't make sense to keep entire revealed sparse trie. let's only keep nodes and values hash maps and any other stuff that we are interested in. can be extracted into SparseTrieNodes or SparseTrieState struct or smth
Member
Author
There was a problem hiding this comment.
made SparseTrieState and put nodes, values, and mask hashmaps
Rjected
force-pushed
the
dan/keep-trie-around
branch
10 times, most recently
from
ea688fc to
f0758aa
Compare
Rjected
force-pushed
the
dan/keep-trie-around
branch
from
f0758aa to
5e65e9b
Compare
rkrasiuk
approved these changes
May 28, 2025
Member
rkrasiuk
left a comment
rkrasiuk
left a comment
There was a problem hiding this comment.
thanks, i like this much more
shekhirin
approved these changes
Jun 6, 2025
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
PeaStew
pushed a commit
to NeuraProtocol/reth-new-consensus
that referenced
this pull request
Jun 24, 2025
Co-authored-by: Alexey Shekhirin <[email protected]> Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
PeaStew
pushed a commit
to NeuraProtocol/reth-new-consensus
that referenced
this pull request
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sends the accounts trie back to the payload processor whenever the sparse trie finishes.
depends on #16179
Previously
reserve_nodestook ~30% of time in revealingMain profile: https://share.firefox.dev/3S18zep
There are now almost no
reserve_nodescalls in account revealing, and the only insertion-related calls take a very small percentage of time.Branch profile: https://share.firefox.dev/456JBlv