fix: Wallet balances not updated on some conditions #12426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memoyil
requested review from
Chef-Yogi,
ChefJerry,
chef-eric,
chef-ryan,
chefjackson,
chefphilip and
thechefpenguin
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
8 Skipped Deployments
|
memoyil
changed the title
memoyil
force-pushed
the
feature/fix_wallet_balance_not_updated
branch
from
81a0f4e to
9963441
Compare
memoyil
force-pushed
the
feature/fix_wallet_balance_not_updated
branch
from
833ee82 to
2debfa2
Compare
memoyil
force-pushed
the
feature/fix_wallet_balance_not_updated
branch
from
11bb170 to
49fd140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wallet balances not updated when
Main Condition is
(if token select modal opened initial fetch is completed and token not yet exist in user's wallet balance)
Then either;
If user collects fee from farm/lp and going back to swap, user can't see the collected token balance (this happens on various transaction types)
User dismiss the swap commit modal after sending trx but before the receipt (which resets the trade therefore useeffect wont work)
User making wrap (which uses another component (WrapCommitButtonReplace) than SwapCommitButton which has the refresh logic)
User making bridge swap output chain balances not updated after successful submit
PR-Codex overview
This PR primarily adds support for handling
outputChainIdin various transaction-related components, enhancing cross-chain functionality and updating state management accordingly.Detailed summary
outputChainIdto transaction-related interfaces and reducers.outputChainId.outputChainIdhandling.WalletBalanceUpdaterto refresh balances based on transaction events.usePublicNodeWaitForTransactionto dispatch wallet transaction events.SwapCommitButtonInnerby removing unused balance refresh logic.