Skip to content

fix: Jupiter solana apis #12417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

fix: Jupiter solana apis #12417

wants to merge 18 commits into from

Conversation

@memoyil
Copy link
Collaborator

@memoyil memoyil commented Oct 2, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on updating the @solana/spl-token-registry dependency, adding new types for token data, and modifying various components to utilize the updated token lists and chain ID. It also refines API endpoints and improves the token fetching logic.

Detailed summary

  • Added @solana/spl-token-registry dependency.
  • Introduced JupRawTokenData type in packages/solana-core-sdk/src/api/type.ts.
  • Updated token URLs in packages/solana-core-sdk/src/api/url.ts.
  • Changed hardcoded chainId values to use ChainID.MainnetBeta.
  • Updated fetching logic for token data in packages/jupiter-terminal/overrides/src/contexts/TokenContextProvider.tsx.
  • Modified token info structure to include new fields in several files.
  • Adjusted API calls to utilize new endpoints for token data.
  • Updated packages/web/src/wallet/hook/useSwitchNetworkV2.ts to point to the new PancakeSwap URL.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: bc129c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
web Ready Ready Preview Comment Oct 8, 2025 7:03am
8 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
aptos-web Ignored Ignored Oct 8, 2025 7:03am
blog Ignored Ignored Oct 8, 2025 7:03am
bridge Ignored Ignored Oct 8, 2025 7:03am
games Ignored Ignored Oct 8, 2025 7:03am
gamification Ignored Ignored Oct 8, 2025 7:03am
solana Ignored Ignored Preview Oct 8, 2025 7:03am
ton Ignored Ignored Oct 8, 2025 7:03am
uikit Ignored Ignored Oct 8, 2025 7:03am

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Oct 2, 2025
@socket-security
Copy link

socket-security bot commented Oct 2, 2025 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@memoyil memoyil force-pushed the feature/fix_solana_apis branch from 815732b to 4ff3a35 Compare October 2, 2025 06:57
@pull-request-size pull-request-size bot added size/XS and removed size/S labels Oct 2, 2025
@vercel vercel bot temporarily deployed to Preview – web October 2, 2025 07:20 Inactive
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Oct 2, 2025
@vercel vercel bot temporarily deployed to Preview – web October 2, 2025 07:29 Inactive
@memoyil memoyil marked this pull request as draft October 2, 2025 07:38
@vercel vercel bot temporarily deployed to Preview – web October 2, 2025 07:40 Inactive
@vercel vercel bot temporarily deployed to Preview – web October 2, 2025 07:44 Inactive
chefphilip
chefphilip reviewed Oct 7, 2025
View reviewed changes
packages/jupiter-terminal/overrides/src/contexts/TokenContextProvider.tsx Outdated
})

const tokenList: TokenInfo[] = Array.from(tokenMap.values()).map((t) => ({
chainId: 101,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@memoyil is it chainId for solana? if yes, chainId should not be hardcoded

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 👍

chefphilip
chefphilip reviewed Oct 7, 2025
View reviewed changes
packages/jupiter-terminal/overrides/src/contexts/TokenContextProvider.tsx

const fetchTokens = async () => {
const [verified, lst] = await Promise.all([
fetch('https://lite-api.jup.ag/tokens/v2/tag?query=verified').then((r) => r.json()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should reuse JUP_TOKEN_LIST somehow. otherwise, need to maintain 2 places

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried to use the url from solana-core-sdk package in jupiter package but solana application gets client side error. since jupiter-terminal package only used by solana app not the pcs web, imo we can keep it like that

i fixed the web side

570dc0f

@memoyil memoyil force-pushed the feature/fix_solana_apis branch 2 times, most recently from 4de95ab to 1b5a6b0 Compare October 7, 2025 18:56
@memoyil memoyil force-pushed the feature/fix_solana_apis branch from b44ca44 to 570dc0f Compare October 7, 2025 19:32
@memoyil memoyil requested a review from chefphilip October 7, 2025 19:45
@memoyil memoyil force-pushed the feature/fix_solana_apis branch from 570dc0f to bc129c1 Compare October 8, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Chef-Yogi Chef-Yogi Awaiting requested review from Chef-Yogi Chef-Yogi is a code owner

@chefjackson chefjackson Awaiting requested review from chefjackson chefjackson is a code owner

@ChefJerry ChefJerry Awaiting requested review from ChefJerry ChefJerry is a code owner

@thechefpenguin thechefpenguin Awaiting requested review from thechefpenguin thechefpenguin is a code owner

@chef-eric chef-eric Awaiting requested review from chef-eric chef-eric is a code owner

@chef-ryan chef-ryan Awaiting requested review from chef-ryan chef-ryan is a code owner

@chefphilip chefphilip Awaiting requested review from chefphilip chefphilip is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@memoyil @chefphilip