Use boto3 for S3 fileadmin #2552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelhwilliams
force-pushed
the
boto-to-boto3
branch
3 times, most recently
from
4d4e6f3 to
97dc171
Compare
19 tasks
samuelhwilliams
force-pushed
the
boto-to-boto3
branch
from
97dc171 to
7ad45ab
Compare
`boto` has long since been deprecated and replaced by `boto3`. This
patch moves over to using the new `boto3` library for interacting with
the S3 bucket.
This is a breaking change because the interface for S3FileAdmin also
changes - rather than taking the AWS keys directly, it now takes a
boto.client('s3') instance.
samuelhwilliams
force-pushed
the
boto-to-boto3
branch
from
7ad45ab to
ad2b8d7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
botohas long since been deprecated and replaced byboto3. This patch moves over to using the newboto3library for interacting with the S3 bucket.This is a breaking change because the interface for S3FileAdmin also changes - rather than taking the AWS keys directly, it now takes a boto.client('s3') instance.
Caveat: I reckon there are a bunch of performance issues with S3FileAdmin that it would be good to close off and improve. But I think that's the case currently, so I'm leaving them out of scope for now. I don't believe this PR makes the situation drastically worse. #2553
fixes: #2347
fixes: #2250