Support Content-Security-Policies via nonce values #2480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelhwilliams
force-pushed
the
support-csp-nonces
branch
2 times, most recently
from
4c8b4b8 to
02126dc
Compare
19 tasks
samuelhwilliams
force-pushed
the
support-csp-nonces
branch
2 times, most recently
from
5e5f7d4 to
e47d0d6
Compare
Content-Security-Policy is a common way of restricting which assets (javascript, styles, etc) are loaded by the browser as a way of preventing a number of vulnerabilities. Flask-Admin loads a fair amount of JavaScript and styling to support its functionality, and previously it has been difficult to get this to pass CSP checks. We can add support for CSP by taking a CSP nonce generator and using that to inject a nonce value wherever we load these resources (either asking the client to download files or with inline scripts/styles).
samuelhwilliams
force-pushed
the
support-csp-nonces
branch
from
e47d0d6 to
fef1357
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content-Security-Policy is a common way of restricting which assets (javascript, styles, etc) are loaded by the browser as a way of preventing a number of vulnerabilities.
Flask-Admin loads a fair amount of JavaScript and styling to support its functionality, and previously it has been difficult to get this to pass CSP checks.
We can add support for CSP by taking a CSP nonce generator and using that to inject a nonce value wherever we load these resources (either asking the client to download files or with inline scripts/styles).
fixes: #2344