Support Gradle 8.13 #547
Merged
Support Gradle 8.13 #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoenig10
commented
May 14, 2025
Comment on lines
+42
to
+46
| // This internal exception was renamed in https://github.com/gradle/gradle/pull/29166 and | ||
| // https://github.com/gradle/gradle/pull/29376 | ||
| private static final Set<String> TOOLCHAIN_EXCEPTIONS = Set.of( | ||
| "org.gradle.jvm.toolchain.internal.NoToolchainAvailableException", | ||
| "org.gradle.jvm.toolchain.internal.install.exceptions.ToolchainProvisioningException"); |
There was a problem hiding this comment.
Is there an alternative solution that does not requiring using internal types?
There was a problem hiding this comment.
Briefly looking, I don't think so. This is definitely the less risky way of checking the exception, although it does mean this feature may break without us knowing this is what the tests in this repo should be checking.
There was a problem hiding this comment.
Hardcoded test versions strike again - will follow up with fixing that.
|
👍 |
|
Released 0.67.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This internal type was renamed in gradle/gradle#29166 and then again in gradle/gradle#29376.