Skip to content

Conversation

LazyAfternoons
Copy link
Contributor

@LazyAfternoons LazyAfternoons commented Jul 24, 2025

List of Changes

  • Update the project according to the upgrade helper;
  • Update a few dependencies which were incompatibile with 0.78;
  • Update ruby and node versions;
  • Update a few components due to the new design system version;
  • Update workflow to use the node version specified in the .node-version file.

Motivation and Context

This PR updates the React Native to version 0.78.3. This is needed in order to support io-react-native-iso18013 library which is compatibile from 0.78.x onward. The new architecture is still disabled as there are some issues with modals on Android.

How Has This Been Tested?

cd example/android && ./gradlew clean && cd ...
rm -rf node_modules 
rm -rf example/node_modules
rm -rf example/ios/DerivedData -> if saved locally
rm -rf example/ios/Pods 

Then follow the README.md. Be sure to pick up the proper ruby and node version.
Test on both platforms that everything is working as before.

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added the ci label Jul 24, 2025
@LazyAfternoons LazyAfternoons marked this pull request as ready for review July 24, 2025 09:04
@LazyAfternoons LazyAfternoons requested a review from a team as a code owner July 24, 2025 09:04
@ale-mazz
Copy link
Contributor

Tested on iOS, everything appears to be working correctly without any regressions.
Tested on Android, and we have a regression in the PID flow, specifically in the CIE+PIN step. Even hardcoding the CIE pin, the modal is broken, and the process is stuck on loading.

@ChrisMattew
Copy link
Collaborator

Tested on iOS, everything appears to be working correctly without any regressions. Tested on Android, and we have a regression in the PID flow, specifically in the CIE+PIN step. Even hardcoding the CIE pin, the modal is broken, and the process is stuck on loading.

Same issue on Android, reverting this change seems to fix the problem.

Except for this, everything seems to work properly!

@LazyAfternoons
Copy link
Contributor Author

Tested on iOS, everything appears to be working correctly without any regressions. Tested on Android, and we have a regression in the PID flow, specifically in the CIE+PIN step. Even hardcoding the CIE pin, the modal is broken, and the process is stuck on loading.

Same issue on Android, reverting this change seems to fix the problem.

Except for this, everything seems to work properly!

I temporary disabled the new architecture, let me know.

Copy link
Contributor

@ale-mazz ale-mazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's also wait for @ChrisMattew approval.

Copy link
Collaborator

@ChrisMattew ChrisMattew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android and it works as expected!
LGTM 💪🏻

@LazyAfternoons LazyAfternoons merged commit aa4c3e1 into master Jul 28, 2025
7 checks passed
@LazyAfternoons LazyAfternoons deleted the SIW-2794-update-rn078 branch July 28, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants