-
Notifications
You must be signed in to change notification settings - Fork 0
feat: [SIW-2794] Update React Native to version 0.78.3 #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tested on iOS, everything appears to be working correctly without any regressions. |
Same issue on Android, reverting this change seems to fix the problem. Except for this, everything seems to work properly! |
I temporary disabled the new architecture, let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's also wait for @ChrisMattew approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Android and it works as expected!
LGTM 💪🏻
List of Changes
ruby
andnode
versions;.node-version
file.Motivation and Context
This PR updates the React Native to version 0.78.3. This is needed in order to support
io-react-native-iso18013
library which is compatibile from 0.78.x onward. The new architecture is still disabled as there are some issues with modals on Android.How Has This Been Tested?
Then follow the README.md. Be sure to pick up the proper ruby and node version.
Test on both platforms that everything is working as before.
Screenshots (if appropriate):
Checklist: