-
Notifications
You must be signed in to change notification settings - Fork 0
feat: [SIW-2206] Update PID data model and issuance flow to 1.0.0 #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
ale-mazz
reviewed
Jun 26, 2025
ale-mazz
approved these changes
Jun 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great job 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Supersedes #208
List of Changes
zod
types for the Credential Issuer's Entity Configurationdc+sd-jwt
client_assertion_type
andclient_assertion
in favor ofOAuth-Client-Attestation
andOAuth-Client-Attestation-PoP
headersstartUserAuthorization
to accept multiple credential IDs in order to get an access token valid for the issuance of multiple credentialsobtainCredential
to fetch the nonce from the nonce endpointobtainCredential
to usecredential_identifier
to request the credentialverifyAndParseCredential
to use thecredential_configuration_id
to map the credential to its configuration (thevct
value does not match anymore)verifyAndParseCredential
to align to the new claims configurationMotivation and Context
This PR implements the IT Wallet Specs v1.0 in the PID issuance flow, and updates several types related to the credentials data model and the entity configuration.
Warning
Introduces breaking changes.
How Has This Been Tested?
Request the PID in the pre-prod Credential Issuer environment.
Screenshots (if appropriate):
Checklist: