Skip to content

Conversation

gispada
Copy link
Collaborator

@gispada gispada commented Apr 14, 2025

Note

Supersedes #208

List of Changes

  • Updated zod types for the Credential Issuer's Entity Configuration
  • Updated credentials format to dc+sd-jwt
  • Removed client_assertion_type and client_assertion in favor of OAuth-Client-Attestation and OAuth-Client-Attestation-PoP headers
  • Modified startUserAuthorization to accept multiple credential IDs in order to get an access token valid for the issuance of multiple credentials
  • Modified obtainCredential to fetch the nonce from the nonce endpoint
  • Modified obtainCredential to use credential_identifier to request the credential
  • Modified verifyAndParseCredential to use the credential_configuration_id to map the credential to its configuration (the vct value does not match anymore)
  • Modified verifyAndParseCredential to align to the new claims configuration
  • Updated several tests with the new credentials/EC data model

Motivation and Context

This PR implements the IT Wallet Specs v1.0 in the PID issuance flow, and updates several types related to the credentials data model and the entity configuration.

Warning

Introduces breaking changes.

How Has This Been Tested?

Request the PID in the pre-prod Credential Issuer environment.

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gispada gispada marked this pull request as ready for review June 23, 2025 12:57
@gispada gispada requested a review from a team as a code owner June 23, 2025 12:57
@gispada gispada requested review from grausof and silvicir June 23, 2025 12:57
Copy link
Contributor

@ale-mazz ale-mazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job 🚀

@gispada gispada merged commit 7bc14e4 into master Jun 30, 2025
7 checks passed
@gispada gispada deleted the SIW-2206-pid-1.0.0 branch June 30, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants