chore: Remove rn-qr-generator, use react-native-qrcode-svg in the example app
#162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastro993
changed the title
rn-qr-generator, use react-native-qrcode-svgrn-qr-generator, use react-native-qrcode-svg in the example app
grausof
approved these changes
Nov 26, 2024
auto-merge was automatically disabled
November 26, 2024 09:18
Pull Request is not mergeable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
rn-qr-generatorwithreact-native-qrcode-svgPodfile.lock, which includes some libraries removed in other PRsMotivation and Context
The
rn-qr-generatorlibrary had issues generating Trustmark QR Codes on Android, which is a large QR code.How Has This Been Tested?
In the example app, generate a trustmark for a credential on Android devices
Checklist: