Skip to content

fix: [SIW-2785] Improve kid string comparison with thumbprint-based key comparison on credential flow #1168

fix: [SIW-2785] Improve kid string comparison with thumbprint-based key comparison on credential flow

fix: [SIW-2785] Improve kid string comparison with thumbprint-based key comparison on credential flow #1168

Triggered via pull request July 22, 2025 09:58
Status Failure
Total duration 1m 29s
Artifacts

code-review.yaml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 error and 2 warnings
code_review
Process completed with exit code 1.
code_review: example/src/components/debug/DebugPrettyPrint.tsx#L93
'_' is already declared in the upper scope on line 15 column 8
code_review: example/src/components/IdpsGrid.tsx#L78
Do not define components during render. React will see a new component type on every render and destroy the entire subtree’s DOM nodes and state (https://reactjs.org/docs/reconciliation.html#elements-of-different-types). Instead, move this component definition out of the parent component “IdpsGrid” and pass data as props. If you want to allow component creation in props, set allowAsProps option to true