-
Notifications
You must be signed in to change notification settings - Fork 22
feat(repository): use git bundles in runners + refactor credentials #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
==========================================
+ Coverage 37.33% 40.07% +2.74%
==========================================
Files 81 86 +5
Lines 5874 5771 -103
==========================================
+ Hits 2193 2313 +120
+ Misses 3522 3275 -247
- Partials 159 183 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0dafa71
to
e5f6954
Compare
9978e89
to
12390b1
Compare
ad1952a
to
27befce
Compare
Documentation is now up-to-date with changes in the PR |
* fix(repo-controller): fix typos in some logs * feat(repo): add annotation on layers for new revisions * feat(run): wip: launch on specific bundle revision * fix(datastore): handle not found error for S3 HeadObject * feat(run): clone on bundles * fix(repo-controller): add errors in warning events * feat(repo-controller): trigger sync on new layer creation * test(layer): fix tests with last branch commit annotation * test(run): fix tests with the revision bundles * test(runner): fix tests with usage of git bundles
…epository provider (#528) * refactor(provider): create dedicated credentials package and rework repository provider * test(credentials): cover most non transient paths * fix(creds): ttl condition on updating credentials * fix(creds): add some comments in credential store * fix(credentials): make mock provider work * feat(credentials): controllers use credentials store * feat(webhook): webhook server use credentials store * feat(manifests): remove secretName from tfrepo * refactor(config): remove deprecated structs for credentials * fix(lint): check err values * fix(test): rework test NormalizeURL * fix(lint): check err values * feat(config): add config key for credentials TTL * feat(repo-controller): update bundle with latest changes * fix(credentials): add secret indexer on field type * fix(providers): use the correct repo URL --------- Co-authored-by: Alan <[email protected]> Co-authored-by: Luca Corrieri <[email protected]> Co-authored-by: Lucas Marques <[email protected]>
27befce
to
301ca65
Compare
This PR include changes from the following PRs:
And the following additional changes that merges the two:
LastRelevantCommit
annotation on TerraformLayersList of tests implemented on the TerraformRepository controller
All tests pass and check if:
LastRelevantCommit
annotation which is now required by the Layer controller to perform any action).Nominal cases:
Error cases: