Skip to content

fix(pullrequests): inherit all properties from original layer in pr layer #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

LucasMrqes
Copy link
Collaborator

@LucasMrqes LucasMrqes commented Mar 5, 2025

Layers generated during the PR / MR flow do not inherit all properties from the original layer. Especially, Terragrunt and OpenTofu setup properties are not inherited, breaking the layer plan/apply.

To prevent this from happening again, I added a small test to check that a layer generated from a PR has the same spec as the original one (except for branch and autoApply field which may be different)

@github-project-automation github-project-automation bot moved this to 📋 Backlog in burrito Mar 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.91%. Comparing base (d8e1149) to head (c2d9a4d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
+ Coverage   43.88%   43.91%   +0.03%     
==========================================
  Files          78       78              
  Lines        5578     5581       +3     
==========================================
+ Hits         2448     2451       +3     
  Misses       2922     2922              
  Partials      208      208              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasMrqes LucasMrqes force-pushed the fix/pr-generated-layers branch from 93fa921 to c2d9a4d Compare March 5, 2025 16:04
@LucasMrqes LucasMrqes requested a review from corrieriluca March 5, 2025 16:05
@LucasMrqes LucasMrqes merged commit 6c78042 into main Mar 5, 2025
7 checks passed
@LucasMrqes LucasMrqes deleted the fix/pr-generated-layers branch March 5, 2025 19:51
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in burrito Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants