Skip to content

fix(datastore): handle not found errors from azure, s3 and gcs #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

corrieriluca
Copy link
Member

For some storage backend implementations, "not found" errors were not implemented for Get and Check operations resulting in unwanted 500 error from the Datastore API.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 62 lines in your changes missing coverage. Please review.

Project coverage is 43.81%. Comparing base (cb02ead) to head (3579db3).

Files with missing lines Patch % Lines
internal/datastore/storage/gcs/gcs.go 0.00% 34 Missing ⚠️
internal/datastore/storage/s3/s3.go 0.00% 22 Missing ⚠️
internal/datastore/storage/azure/azure.go 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
- Coverage   44.24%   43.81%   -0.43%     
==========================================
  Files          78       78              
  Lines        5517     5571      +54     
==========================================
  Hits         2441     2441              
- Misses       2868     2922      +54     
  Partials      208      208              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlanLonguet AlanLonguet merged commit af6af4c into main Jan 17, 2025
7 checks passed
@AlanLonguet AlanLonguet deleted the fix/storage-errors branch January 17, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants