Skip to content

feat(datastore): remove all leading slashes in object key prefixes #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

LucasMrqes
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.99%. Comparing base (96f8443) to head (610b3fa).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/datastore/storage/common.go 75.00% 1 Missing ⚠️
internal/datastore/storage/s3/s3.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #379   +/-   ##
=======================================
  Coverage   50.99%   50.99%           
=======================================
  Files          73       73           
  Lines        4334     4334           
=======================================
  Hits         2210     2210           
  Misses       1935     1935           
  Partials      189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@corrieriluca
Copy link
Member

This PR fixes #332

@corrieriluca corrieriluca merged commit 10685b1 into main Nov 15, 2024
8 checks passed
@corrieriluca corrieriluca deleted the fix/s3-prefix branch November 15, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants