This repository was archived by the owner on May 1, 2024. It is now read-only.
Bump CI python version to 3.11 to produce working binary #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It also for some reason seems to works around encode/httpcore#663 - before I bumped the python version I was explicitly importing anyio in __main__.py to avoid the race condition mentioned, but this doesn't *seem* to be required after the python version bump - perhaps it has pulled in newer version of httpcore? (This also explicitly sets the step ID for the python set-up, so we can key the cache properly based on the python version.)
Member
|
Alright I'm not a python person either so I'm gonna merge it and let's hope for the best 🤞🏻 |
Elsie19
approved these changes
Feb 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump CI python version to 3.11; this fixes errors from anyio regarding exceptiongroup.
It also for some reason seems to work around encode/httpcore#663 - before I bumped the python version I was explicitly importing anyio in
__main__.pyto avoid the race condition mentioned in encode/httpcore#692, but this doesn't seem to be required after the python version bump - perhaps it has pulled in newer version of httpcore?(This also explicitly sets the step ID for the python set-up, so we can key the cache properly based on the python version.)
Fixes: #202