Add validation tests #614
Add validation tests #614
Conversation
There was a problem hiding this comment.
@TG1999 Thanks! these should be combined in each of the existing JSON files... for instance, for tests/types/conda-validation-tests.json, merge these in https://github.com/package-url/purl-spec/blob/main/tests/types/conda-test.json
And when doing so, please make sure there is no duplicate... you also need to conform to the new schema.
TG1999
force-pushed
the
add_validation_tests
branch
2 times, most recently
from
7e01a54 to
07d9554
Compare
schemas/purl-test.schema.json
Outdated
| }, | ||
| "expected_messages": { | ||
| "title": "Expected messages", | ||
| "description": "Validation messages expected for this test. Can be null or a list of strings.", |
There was a problem hiding this comment.
Are implementations really expected to produce exactly these text messages?
There was a problem hiding this comment.
@matt-phylum re:
Are implementations really expected to produce exactly these text messages?
good point. I have mixed feeling on that alright. One part of me says it would be really nice to have the same validation error messages everywhere. One part of me says it is not critical and may put too much burden on authors. What is your preference?
TG1999
force-pushed
the
add_validation_tests
branch
2 times, most recently
from
f645ee5 to
ce67457
Compare
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
TG1999
force-pushed
the
add_validation_tests
branch
from
0124335 to
f3cc7ae
Compare
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Add tests for validating each PURL type.