Skip to content

Conversation

@muschellij2
Copy link
Contributor

Added passthrough options for a keyfile, as requested in meztez/plumberDeploy#12

Description

Now you can specify a keyfile for any operation that requires ssh. Related to #155

Related Issue

#155

@sckott sckott added this to the v1.0 milestone Oct 26, 2020
@sckott
Copy link
Collaborator

sckott commented Oct 26, 2020

thanks @muschellij2

sadly i still don't have tests for most things here. have you tested the added parameters yourself?

@muschellij2
Copy link
Contributor Author

@Adamoso - I made this to try to address your issue at rstudio/plumber#524. Would you be able to test?

@arydelek
Copy link

Hello @muschellij2!
Thank you for addressing this issue. I will test it and share my results here.

@muschellij2
Copy link
Contributor Author

Any thoughts on this? I think travis fails were due to DO tokens.

@sckott
Copy link
Collaborator

sckott commented Nov 16, 2020

@muschellij2 are you asking me? or are you waiting on response from @Adamoso ?

@muschellij2
Copy link
Contributor Author

Apologies, asking from @Adamoso. Also, unsure if the failures are true or false positives, which I think @sckott can answer. Also, just seeing if you need additional tests for this. I don't pass in keyfiles or other params to use this, but I think it could be useful if you do.

@arydelek
Copy link

@muschellij2 sorry for taking so long! I was finally able to test most of the functionalities with two different keys. Everything seems to function properly. I can't however find any reason the tests are failing as when I was using the modified functions without specifying new parameters it seemed to work just the same as before.

@sckott
Copy link
Collaborator

sckott commented Nov 19, 2020

tests failing b/c token not available in PR's

having a look

@sckott
Copy link
Collaborator

sckott commented Nov 19, 2020

looks good to me

@sckott sckott merged commit ff397e7 into pachadotdev:master Nov 19, 2020
@sckott sckott modified the milestones: v1.0, v0.9.4 Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants