Skip to content

Conversation

@muschellij2
Copy link
Contributor

Description

Created simple wrapper install_github_r_package for installing r packages from remotes. Performs a check, similar to plumber:::droplet_capture to see if the package is installed already; if not, it installs remotes. Then uses remotes::install_github to install the

Related Issue

Example

install_github_r_package("sckott/analogsea")

Did not find tests for install_r_package so wasn't sure where to put install_github_r_package tests.

@sckott
Copy link
Collaborator

sckott commented Feb 11, 2020

thanks very much @muschellij2

A few things:

  1. There's a bunch of white space changes - try to keep those to a minimum
  2. There's two functions added. droplet_ls was introduced in the PR but not mentioned. Open a separate PR for that. I'm not sure I'd accept it though since ls is pretty simple to just do as droplet_ssh(droplet, "ls")
  3. You don't need to namespace fxn calls within the pkg that those fxns are from, e.g, foo::bar() can just be bar()

it's really hard to test this pkg, but does the install_github_r_package fxn work for you? i can test it too.

@muschellij2
Copy link
Contributor Author

Sorry:

  1. WS came from RStudio loading and formatting.
  2. Removed droplet_ls. Agree it's simple, but I've found myself having to do it 5-6 times, and it seemed nice to have convenience function.
  3. install_github_r_package has worked for me.

@sckott
Copy link
Collaborator

sckott commented Feb 12, 2020

thanks, i'll test it out and get back here

@sckott
Copy link
Collaborator

sckott commented Feb 13, 2020

thanks

@sckott sckott merged commit 0c67872 into pachadotdev:master Feb 13, 2020
@sckott sckott added this to the v0.9 milestone Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants