Support for arrays of extern instances #5338
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDodd
force-pushed
the
cdodd-externarray
branch
from
603b698 to
764e40f
Compare
fruffy
added
the
core
|
I haven't kept track, is this something that is already part of the spec or do we have a related spec issue? Is this an alternative solution to #5330? |
|
The array change to the spec has not yet been pulled in (p4lang/p4-spec#1360), but it includes an allowance for arrays of extern instances (for architectures that want to support it). This is orthogonal to #5330, though necessary to support an alternative using (arrays of) externs with implicit read/assign methods. (so in that sense it is an alternative) |
ChrisDodd
force-pushed
the
cdodd-externarray
branch
from
764e40f to
1dad839
Compare
ChrisDodd
force-pushed
the
cdodd-externarray
branch
from
1dad839 to
eedb020
Compare
|
@jafingerhut @vgurevich @fruffy @asl Anyone have any further comments on this? Any objections? |
ChrisDodd
force-pushed
the
cdodd-externarray
branch
2 times, most recently
from
6970e59 to
3c2ad82
Compare
Signed-off-by: Chris Dodd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending array support to allow arrays of extern instances.