Skip to content

Conversation

@eguguchkin
Copy link
Contributor

@eguguchkin eguguchkin commented Oct 25, 2025

Before: the storage-state.json file was created during the initialization of the FracManager structure.
Now: The file is written only when the storage state is explicitly changed.

This allows us to avoid creating a temporary directory and cleaning it up in tests that create a FracManager.


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2025

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.86%. Comparing base (36016e6) to head (810fef6).

Files with missing lines Patch % Lines
fracmanager/storage_state.go 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
- Coverage   71.88%   71.86%   -0.02%     
==========================================
  Files         199      199              
  Lines       14570    14570              
==========================================
- Hits        10473    10471       -2     
- Misses       3364     3365       +1     
- Partials      733      734       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eguguchkin eguguchkin modified the milestones: v0.62.3, v0.62.5 Oct 29, 2025
@eguguchkin eguguchkin force-pushed the 0-do-not-write-state-on-init branch from b132d4f to 7017aab Compare November 5, 2025 19:18
@eguguchkin eguguchkin requested review from cheb0 and moflotas November 7, 2025 11:57
@eguguchkin eguguchkin merged commit 5888583 into main Nov 10, 2025
8 checks passed
@eguguchkin eguguchkin deleted the 0-do-not-write-state-on-init branch November 10, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants