-
-
Notifications
You must be signed in to change notification settings - Fork 269
Re-enable checkmake #5817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Re-enable checkmake #5817
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR re-enables the checkmake linter for Makefiles by removing the disabled configuration that was previously in place due to security concerns. The changes restore checkmake functionality across all MegaLinter flavors and deployment workflows.
- Removes the
disabled: true
flag and security warning from the makefile descriptor - Adds checkmake back to all flavor configurations and Dockerfiles
- Updates deployment workflows to include checkmake in the build matrix
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
megalinter/descriptors/makefile.megalinter-descriptor.yml | Removes disabled flag and security warning for checkmake |
megalinter/descriptors/all_flavors.json | Adds MAKEFILE_CHECKMAKE to all flavor configurations |
flavors/*/flavor.json | Adds checkmake to individual flavor linter lists |
flavors/*/Dockerfile | Adds checkmake Docker image and binary installation |
Dockerfile | Adds checkmake to main MegaLinter Docker image |
.github/workflows/deploy-*.yml | Adds checkmake to deployment workflow matrices |
✅
|
This pull request has been automatically marked as stale because it has not had recent activity. If you think this pull request should stay open, please remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bug: Security Risks with Re-enabled Linter
Re-enabling the checkmake
linter, which was previously disabled due to known security issues (checkmake/checkmake#99). There's no indication these security concerns have been resolved, potentially reintroducing known vulnerabilities.
megalinter/descriptors/makefile.megalinter-descriptor.yml#L35-L37
megalinter/megalinter/descriptors/makefile.megalinter-descriptor.yml
Lines 35 to 37 in 1f7aed5
- **Build optimization suggestions** improving compilation efficiency | |
name: MAKEFILE_CHECKMAKE | |
linter_url: https://github.com/mrtazz/checkmake |
megalinter/descriptors/makefile.megalinter-descriptor.yml#L25-L28
megalinter/megalinter/descriptors/makefile.megalinter-descriptor.yml
Lines 25 to 28 in 1f7aed5
- **Makefile rule validation** ensuring proper target and dependency syntax | |
- **Proper indentation checking** verifying correct tab usage vs. spaces | |
- **Variable usage verification** detecting undefined or misused variables | |
- **Target naming convention enforcement** following Makefile best practices |
No description provided.