feat!: introduce attrs setting
#949
Open
+373
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahl
reviewed
Jan 4, 2026
Collaborator
ahl
left a comment
ahl
left a comment
There was a problem hiding this comment.
This looks good; do you have a proposal for how we test it?
typify-impl/src/util.rs
Outdated
| pub(crate) fn type_patch( | ||
| type_space: &TypeSpace, | ||
| type_name: String, | ||
| ) -> (String, BTreeSet<String>, BTreeSet<String>) { |
Collaborator
There was a problem hiding this comment.
Maybe at this point we should have a struct with named fields..
Contributor
Author
|
I'll update the documentation, add it as an option to the CLI, clean up the code, and possibly add some tests shortly. |
ericszentivanyi
changed the title
attrs settingattrs setting
ericszentivanyi
commented
Jan 4, 2026
|
|
||
| /// Add an additional derive macro to apply to all defined types. | ||
| #[arg(short, long = "additional-derive", value_name = "derive")] | ||
| #[arg(short = 'd', long = "additional-derive", value_name = "derive")] |
Contributor
Author
There was a problem hiding this comment.
Updated the shorthand for the additional-derive option to resolve the conflict with the new additional-attr option. This is a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
attrssetting that can be used to apply attributes to generated types.Supersedes #707