Skip to content

Conversation

Sysix
Copy link
Member

@Sysix Sysix commented Dec 1, 2024

closes #7240

Can not find a better place / method to add a test case

Copy link
Contributor

graphite-app bot commented Dec 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-cli Area - CLI label Dec 1, 2024
@Sysix Sysix changed the title Fix lint detect vitest jest alias rules fix(linter): detect vitest jest alias rules Dec 1, 2024
@github-actions github-actions bot added the C-bug Category - Bug label Dec 1, 2024
@github-actions github-actions bot added the A-linter Area - Linter label Dec 1, 2024
Copy link

codspeed-hq bot commented Dec 1, 2024

CodSpeed Performance Report

Merging #7567 will not alter performance

Comparing Sysix:fix-lint-detect-vitest-jest-alias-rules (03183ae) with main (33e5a49)

Summary

✅ 30 untouched benchmarks

@Sysix Sysix marked this pull request as ready for review December 1, 2024 14:34
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict.

Copy link
Member

@camchenry camchenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict aside, I think this makes sense

@Sysix Sysix requested a review from Boshen December 2, 2024 17:19
@Boshen Boshen merged commit 810671a into oxc-project:main Dec 3, 2024
26 checks passed
@oxc-bot oxc-bot mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area - CLI A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linter: jest and vitest compatible rules are reported as not supported
5 participants