Skip to content

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 25, 2025

var Object; Object.create() was treated as side effect free, but this should be treated as side effectful.

@github-actions github-actions bot added A-minifier Area - Minifier C-bug Category - Bug labels Aug 25, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red marked this pull request as ready for review August 25, 2025 13:44
@Copilot Copilot AI review requested due to automatic review settings August 25, 2025 13:44
Copy link

codspeed-hq bot commented Aug 25, 2025

CodSpeed Instrumentation Performance Report

Merging #13292 will not alter performance

Comparing 08-25-fix_ecmascript_treat_shadowed_global_calls_correctly (5d898e8) with main (593f54c)

Summary

✅ 34 untouched benchmarks

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 25, 2025
Copy link
Member

Boshen commented Aug 25, 2025

Merge activity

  • Aug 25, 2:47 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 25, 2:47 PM UTC: Boshen added this pull request to the Graphite merge queue.
  • Aug 25, 2:56 PM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Test wasm32-wasip1-threads', 'Bench lexer', 'Bench parser', 'Bench transformer', 'Bench semantic', 'Bench minifier', 'Bench codegen', 'Bench formatter', 'Bench linter').
  • Aug 25, 5:16 PM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Aug 25, 5:16 PM UTC: Merged by the Graphite merge queue.

`var Object; Object.create()` was treated as side effect free, but this should be treated as side effectful.
@graphite-app graphite-app bot force-pushed the 08-25-fix_ecmascript_treat_shadowed_global_calls_correctly branch from 0c57f1a to 5d898e8 Compare August 25, 2025 14:52
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 25, 2025
@graphite-app graphite-app bot merged commit 5d898e8 into main Aug 25, 2025
37 of 46 checks passed
@graphite-app graphite-app bot deleted the 08-25-fix_ecmascript_treat_shadowed_global_calls_correctly branch August 25, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-minifier Area - Minifier C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants