-
-
Notifications
You must be signed in to change notification settings - Fork 646
refactor(linter): message_to_message_with_position
helper function
#13140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(linter): message_to_message_with_position
helper function
#13140
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #13140 will not alter performanceComparing Summary
Footnotes |
f60836c
to
e58ff2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors message conversion logic by extracting helper functions to improve code reusability. The main purpose is to create a message_to_message_with_position
helper function that will be needed later for TsGoLintState
.
- Extracts message conversion logic from
Runtime::run_source
into standalone helper functions - Moves the helper functions to the
fixer
module for better organization - Simplifies the runtime code by replacing inline logic with a single function call
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
crates/oxc_linter/src/service/runtime.rs | Removes inline message conversion logic and replaces with call to extracted helper function |
crates/oxc_linter/src/fixer/mod.rs | Adds new message_to_message_with_position and fix_to_fix_with_position helper functions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merge activity
|
…13140) Is needed later for `TsGoLintState`
e58ff2a
to
437a63d
Compare
Is needed later for
TsGoLintState