Skip to content

Conversation

Sysix
Copy link
Member

@Sysix Sysix commented Aug 16, 2025

Is needed later for TsGoLintState

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 16, 2025
Copy link
Member Author

Sysix commented Aug 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Aug 16, 2025

CodSpeed Instrumentation Performance Report

Merging #13140 will not alter performance

Comparing 08-16-refactor_linter_message_to_message_with_position_helper_function (437a63d) with main (09b597f)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (f6ac2e6) during the generation of this report, so 09b597f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Sysix Sysix force-pushed the 08-16-refactor_linter_message_to_message_with_position_helper_function branch from f60836c to e58ff2a Compare August 16, 2025 13:46
@Sysix Sysix marked this pull request as ready for review August 16, 2025 14:28
@Copilot Copilot AI review requested due to automatic review settings August 16, 2025 14:28
@Sysix Sysix requested a review from camc314 as a code owner August 16, 2025 14:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors message conversion logic by extracting helper functions to improve code reusability. The main purpose is to create a message_to_message_with_position helper function that will be needed later for TsGoLintState.

  • Extracts message conversion logic from Runtime::run_source into standalone helper functions
  • Moves the helper functions to the fixer module for better organization
  • Simplifies the runtime code by replacing inline logic with a single function call

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
crates/oxc_linter/src/service/runtime.rs Removes inline message conversion logic and replaces with call to extracted helper function
crates/oxc_linter/src/fixer/mod.rs Adds new message_to_message_with_position and fix_to_fix_with_position helper functions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Aug 16, 2025
Copy link
Contributor

camc314 commented Aug 16, 2025

Merge activity

  • Aug 16, 2:29 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 16, 2:29 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Aug 16, 2:31 PM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'autofix').
  • Aug 16, 2:39 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 16, 2:39 PM UTC: Sysix added this pull request to the Graphite merge queue.
  • Aug 16, 2:40 PM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 08-16-refactor_linter_message_to_message_with_position_helper_function branch from e58ff2a to 437a63d Compare August 16, 2025 14:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 16, 2025
@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label Aug 16, 2025
@graphite-app graphite-app bot merged commit 437a63d into main Aug 16, 2025
26 of 27 checks passed
@graphite-app graphite-app bot deleted the 08-16-refactor_linter_message_to_message_with_position_helper_function branch August 16, 2025 14:40
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants