Skip to content

FEAT: Implement Likelihood-Ratio test #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

FEAT: Implement Likelihood-Ratio test #178

wants to merge 8 commits into from

Conversation

PABannier
Copy link

@PABannier PABannier commented Oct 17, 2023 •
edited
Loading

This PR implements the Likelihood-Ratio test to assess the statistical significance of log fold changes.

It proceeds as follows:

  • Add the LRT logic comparing a full and reduced model where the reduced model removes a single LFC term (df = 1)
  • LRT supporting custom formulas as in the original DeSeq2 implementation.

Closes #176

@PABannier PABannier requested a review from a user October 17, 2023 09:50
@PABannier PABannier marked this pull request as draft October 17, 2023 10:15
@BorisMuzellec BorisMuzellec mentioned this pull request May 21, 2024
Open
kimsjune added a commit to kimsjune/PyDESeq2 that referenced this pull request Jun 5, 2025
@kimsjune
Manually added LRT logic from owkin#178
d507fba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BorisMuzellec BorisMuzellec Awaiting requested review from BorisMuzellec BorisMuzellec is a code owner

@maikia maikia Awaiting requested review from maikia maikia is a code owner

@arthurPignetOwkin arthurPignetOwkin Awaiting requested review from arthurPignetOwkin

@umarteauowkin umarteauowkin Awaiting requested review from umarteauowkin umarteauowkin will be requested when the pull request is marked ready for review umarteauowkin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding LRT test
3 participants
@PABannier @bbdnr @alexandrenowak