Skip to content

feat(sdk.cdsclient): allow to pass modifiers on template apply #6249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2022
Merged

feat(sdk.cdsclient): allow to pass modifiers on template apply #6249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/cdsclient/client_template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,15 @@ func (c *client) TemplateGetAll() ([]sdk.WorkflowTemplate, error) {
return wts, nil
}

func (c *client) TemplateApply(groupName, templateSlug string, req sdk.WorkflowTemplateRequest) (*tar.Reader, error) {
func (c *client) TemplateApply(groupName, templateSlug string, req sdk.WorkflowTemplateRequest, mods ...RequestModifier) (*tar.Reader, error) {
url := fmt.Sprintf("/template/%s/%s/apply", groupName, templateSlug)

bs, err := json.Marshal(req)
if err != nil {
return nil, err
}

body, _, _, err := c.Request(context.Background(), "POST", url, bytes.NewReader(bs))
body, _, _, err := c.Request(context.Background(), "POST", url, bytes.NewReader(bs), mods...)
if err != nil {
return nil, err
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/cdsclient/interface.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ type Filter struct {
type TemplateClient interface {
TemplateGet(groupName, templateSlug string) (*sdk.WorkflowTemplate, error)
TemplateGetAll() ([]sdk.WorkflowTemplate, error)
TemplateApply(groupName, templateSlug string, req sdk.WorkflowTemplateRequest) (*tar.Reader, error)
TemplateApply(groupName, templateSlug string, req sdk.WorkflowTemplateRequest, mods ...RequestModifier) (*tar.Reader, error)
TemplateBulk(groupName, templateSlug string, req sdk.WorkflowTemplateBulk) (*sdk.WorkflowTemplateBulk, error)
TemplateGetBulk(groupName, templateSlug string, id int64) (*sdk.WorkflowTemplateBulk, error)
TemplatePull(groupName, templateSlug string) (*tar.Reader, error)
Expand Down
26 changes: 18 additions & 8 deletions sdk/cdsclient/mock_cdsclient/interface_mock.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.