refactor: move from io/ioutil to io and os packages #5999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The io/ioutil package has been deprecated as of Go 1.16, see https://golang.org/doc/go1.16#ioutil. This commit replaces the existing io/ioutil functions with their new definitions in io and os packages. Signed-off-by: Eng Zer Jun <[email protected]>
Juneezee
requested review from
fsamin,
richardlt,
sguiheux and
yesnault
as code owners
sguiheux
approved these changes
Nov 5, 2021
richardlt
approved these changes
Nov 5, 2021
Collaborator
|
CDS Report build-all-cds#16745.0 ✘
|
yesnault
approved these changes
Nov 5, 2021
yesnault
requested changes
Nov 5, 2021
Member
yesnault
left a comment
yesnault
left a comment
There was a problem hiding this comment.
# github.com/ovh/cds/tools/smtpmock
./client.go:49:14: undefined: io.ReadAll
Juneezee
commented
Nov 5, 2021
| @@ -1,5 +1,5 @@ | |||
| # build stage | |||
| FROM golang:1.15 AS builder | |||
| FROM golang:1.17 AS builder | |||
Contributor
Author
There was a problem hiding this comment.
# github.com/ovh/cds/tools/smtpmock ./client.go:49:14: undefined: io.ReadAll
@yesnault This should be fixed now. The SMTPMock Dockerfile is using Go 1.15 instead of 1.17.
Member
There was a problem hiding this comment.
@Juneezee yes, thank you. Can you re-run go mod tidy in tools/smtpmock please? seems that go.mod is no up to date
Contributor
Author
There was a problem hiding this comment.
@yesnault Done. Please take a look again. Thank you.
Signed-off-by: Eng Zer Jun <[email protected]>
yesnault
approved these changes
Nov 5, 2021
fsamin
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
io/ioutilpackage has been deprecated in Go 1.16 (See https://golang.org/doc/go1.16#ioutil). Since CDS has been upgraded to Go 1.17 (#5973), this PR replaces the existingio/ioutilfunctions with their new definitions inioandospackages.