Skip to content

Conversation

@jerome-benoit
Copy link
Contributor

@jerome-benoit jerome-benoit commented Oct 15, 2023

What does this PR do?

Add threadId property missing on Worker instance from node:worker_threads module.

  • Code changes

How did you verify your code works?

  • I ran make js and committed the transpiled changes
  • I or my editor ran Prettier on the changed files (or I ran bun fmt)
  • I included a test for the new code, or an existing test covers it

@jerome-benoit jerome-benoit marked this pull request as draft October 15, 2023 20:37
jerome-benoit and others added 5 commits October 15, 2023 23:05
Signed-off-by: Jérôme Benoit <[email protected]>
Signed-off-by: Jérôme Benoit <[email protected]>
Signed-off-by: Jérôme Benoit <[email protected]>
Signed-off-by: Jérôme Benoit <[email protected]>
@jerome-benoit jerome-benoit marked this pull request as ready for review October 15, 2023 22:10
@jerome-benoit jerome-benoit changed the title fix: ensure threadId property is exposed on worker_threads instance fix(node:worker_threads): ensure threadId property is exposed on worker_threads instance Oct 15, 2023
Copy link
Contributor

@Electroid Electroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@Electroid Electroid merged commit d9c0273 into oven-sh:main Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants