Skip to content

Conversation

@Electroid
Copy link
Contributor

@Electroid Electroid commented Oct 13, 2023

What does this PR do?

Fixes Bun.dns and node:dns from returning incorrect addresses when a family is specified. This was because we were not setting the proper hints.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

I wrote automated tests.

Closes #6452

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

prettier errors have been resolved. Thank you.

#3965ee9642a85b7f56c4ffa81699ae687c16db8e

@Electroid Electroid changed the title Fix #6452 Fix dns.lookup returning wrong address for family Oct 13, 2023
@github-actions
Copy link
Contributor

@Electroid 3 files with test failures on linux-x64-baseline:

  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts

View test output

#3965ee9642a85b7f56c4ffa81699ae687c16db8e

@github-actions
Copy link
Contributor

@Electroid 3 files with test failures on linux-x64:

  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts

View test output

#3965ee9642a85b7f56c4ffa81699ae687c16db8e

@github-actions
Copy link
Contributor

@Electroid 7 files with test failures on bun-darwin-aarch64:

  • test/bundler/esbuild/default.test.ts
  • test/integration/next/default-pages-dir/test/dev-server.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts

View test output

#3965ee9642a85b7f56c4ffa81699ae687c16db8e

@github-actions
Copy link
Contributor

@Electroid 9 files with test failures on bun-darwin-x64:

  • test/cli/install/bunx.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts
  • test/js/third_party/prompts/prompts.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js
  • test/js/web/worker.test.ts

View test output

#3965ee9642a85b7f56c4ffa81699ae687c16db8e

@github-actions
Copy link
Contributor

@Electroid 7 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/third_party/postgres/postgres.test.ts
  • test/js/third_party/prisma/prisma.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#3965ee9642a85b7f56c4ffa81699ae687c16db8e

@Jarred-Sumner Jarred-Sumner merged commit 77d7e47 into main Oct 14, 2023
@Jarred-Sumner Jarred-Sumner deleted the fix-6452 branch October 14, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dns:resolve4 and dns:resolve6 return incorrect data

3 participants