Skip to content

Conversation

@vladaman
Copy link
Contributor

@vladaman vladaman commented Oct 1, 2023

What does this PR do?

Lambda string response doesn't need to be stringified. This is especially important when we want to respond to services such as Congito, which require JSON output.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Added type check for string:

body: response === null ? null : (typeof response === 'string' ? response : JSON.stringify(response)),

@Jarred-Sumner Jarred-Sumner merged commit 68324da into oven-sh:main Oct 20, 2023
@Jarred-Sumner
Copy link
Collaborator

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants