Add define option to test section in bunfig.toml #21607
Open
+186
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for test-specific define values in bunfig.toml under the [test] section. Test-specific defines will override global defines with the same key.
Example usage:
[test]
define = { "process.env.NODE_ENV" = "'test'", "TEST_MODE" = "true" }
- Modified bunfig.zig to parse the define field within the [test] section
- Implemented merging logic so test-specific defines override global defines
- Added tests to verify the functionality
- Updated documentation to include the new test.define option
Changed from [test.define] table syntax to inline define = {...} syntax
to match the other test cases
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
RiskyMH
reviewed
Aug 5, 2025
| ]); | ||
|
|
||
| expect(exitCode).toBe(0); | ||
| expect(stdout).toContain("1 pass"); |
There was a problem hiding this comment.
35 | expect(stdout).toContain("1 pass");
^
error: expect(received).toContain(expected)
Expected to contain: "1 pass"
Received: "bun test v1.2.20-canary.1 (caee0990)\n"
at <anonymous> (C:\buildkite-agent\builds\EC2AMAZ-FCSPDJI\bun\bun\test\config\bunfig\test-define.test.ts:35:18)
✗ test.define in bunfig.toml [63.00ms]this test seems to be failing in CI: https://buildkite.com/bun/bun/builds/22202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds support for test-specific define values in bunfig.toml under the [test] section. Test-specific defines will override global defines with the same key.
Example usage:
How did you verify your code works?