-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix(tls) fix ciphers #21545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix(tls) fix ciphers #21545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated 4:09 PM PT - Aug 4th, 2025
❌ @cirospaciari, your commit 3caf845 has 5 failures in
🧪 To try this PR locally: bunx bun-pr 21545 That installs a local version of the PR into your bun-21545 --bun |
Is this PR merged into Bun v1.2.0? Since in my case it has not solved the connection problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses same ciphers than node.js for compatibility and do the same error checking on empty ciphers
Fixes #9425
Fixes #21518
Fixes #19859
Fixes #18980
You can see more about redis ciphers here https://redis.io/docs/latest/operate/rs/security/encryption/tls/ciphers/ this should fix redis related ciphers issues
How did you verify your code works?
Tests