Skip to content

fix(tls) fix ciphers #21545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Aug 5, 2025
Merged

fix(tls) fix ciphers #21545

merged 35 commits into from
Aug 5, 2025

Conversation

cirospaciari
Copy link
Member

@cirospaciari cirospaciari commented Aug 1, 2025

What does this PR do?

Uses same ciphers than node.js for compatibility and do the same error checking on empty ciphers
Fixes #9425
Fixes #21518
Fixes #19859
Fixes #18980

You can see more about redis ciphers here https://redis.io/docs/latest/operate/rs/security/encryption/tls/ciphers/ this should fix redis related ciphers issues

How did you verify your code works?

Tests

@robobun
Copy link
Collaborator

robobun commented Aug 1, 2025

Updated 4:09 PM PT - Aug 4th, 2025

@cirospaciari, your commit 3caf845 has 5 failures in Build #22185:


🧪   To try this PR locally:

bunx bun-pr 21545

That installs a local version of the PR into your bun-21545 executable, so you can run:

bun-21545 --bun

@cirospaciari cirospaciari marked this pull request as ready for review August 2, 2025 00:45
@Jarred-Sumner Jarred-Sumner merged commit ed6f099 into main Aug 5, 2025
58 of 61 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/fix-tls-ciphers branch August 5, 2025 02:42
@devcaeg
Copy link

devcaeg commented Aug 11, 2025

Is this PR merged into Bun v1.2.0? Since in my case it has not solved the connection problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants