fix: pass canSeeReorderButtons as a property from the table to the header and row to fix header misalignment #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ader and row to fix header misalignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty sure this fixes #164. It seems that the
ResourceTableHeaderandResourceTableRowcouldn't actually see the resource which was referenced in theReordersResourcesmixin (maybe just when it was a belongsTo/hasMany relationship). I changed the components to receive thecanSeeReorderButtonsproperty from theResourceTablecontext.This seems to have fixed the issue for me and I couldn't find another place that the
ReordersResourcesmixin was used so I removed the import in the header and row components. Let me know if you find any side effects or issues with this.