Change to handle variables listed in exported directive as unknown usage
#234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Good work @ota-meshi! Apart from my above comment, I don't have much to say about this PR. Merge this anytime you think it's ready. |
RunDevelopment
requested changes
Jun 9, 2021
| /** | ||
| * Find function node | ||
| */ | ||
| function findFunction( |
Collaborator
There was a problem hiding this comment.
This function should probably be placed and exported in the same file as findVariable.
| ObjectPattern, | ||
| Pattern, | ||
| } from "estree" | ||
| import { findVariable, getParent } from "." |
Collaborator
There was a problem hiding this comment.
That's a circular dependency and I really don't like those.
I suggest moving the code (without the export ... from "..."s) in ast-util/index.ts into its own file ast-util/something.ts. By simply doing an export * from "./something" in ast-util/index.ts and changing the import here to ./something, we can get rid of the circular dependency.
Owner
Author
|
Thank you for checking! I changed this PR. |
RunDevelopment
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-unused-capturing-grouprule, theno-useless-flagrule, and the rules usinggetUsageOfPattern, have been changed to handle theexporteddirective.no-unused-capturing-grouprule, theno-useless-flagrule, and thegetUsageOfPatternfunction. In this PR, variable tracking is shared with theextractExpressionReferencesfunction, and it has been changed to use this function.no-unused-capturing-grouprule has improved iteration tracking.no-unused-capturing-grouprule was handling has been separated by theextractPropertyReferencesfunction. This can also be used to detect thedflag, which is probably unused.close #227