Skip to content

Conversation

@ota-meshi
Copy link
Owner

@ota-meshi ota-meshi commented Jun 2, 2021

Related to #91 (comment).

@RunDevelopment
Copy link
Collaborator

I think that we shouldn't solely rely on new RegExpValidator({ strict: true }) here. The problems with RegExpValidator are that the error messages aren't precise (we only know that something is wrong but we can't give the exact location) and that reports aren't fixable.

I think that we should have our own logic that produces fixable reports (mostly dealing with required/forbidden escapes). Only after that logic can't find any problems will we use RegExpValidator (to make sure we haven't missed anything).

Shall I make a PR targeting this branch?

@ota-meshi
Copy link
Owner Author

Shall I make a PR targeting this branch?

Yes, thank you

* Improved `regexp/strict` rule

* Update

* Disable validator for patterns with named backrefs
@RunDevelopment RunDevelopment merged commit 3b076a7 into master Jun 4, 2021
@RunDevelopment RunDevelopment deleted the strict branch June 4, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants