Add option to allow only partial use to the allowTop option of regexp/no-useless-non-capturing-group rule.
#215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exp/no-useless-non-capturing-group` rule.
Closed
RunDevelopment
requested changes
May 30, 2021
Collaborator
RunDevelopment
left a comment
RunDevelopment
left a comment
There was a problem hiding this comment.
Thank you @ota-meshi!
Two minor things but apart from that good to go.
Owner
Author
|
Thank you for your review! I updated it, so could you check it again? |
Owner
Author
|
I noticed that I haven't changed about autofix yet. I will fix it again. |
Owner
Author
I fixed it. |
Collaborator
|
Thank you @ota-meshi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #181 (comment).