Update no-dupe-characters-character-class
#191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
ota-meshi
approved these changes
May 2, 2021
Owner
ota-meshi
left a comment
ota-meshi
left a comment
There was a problem hiding this comment.
Thank you for many improvements! LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the
no-dupe-characters-character-classrule.Changes:
[a-bc-db-c]was previously reported as a bunch of intersection messages. The rule now only reports thatb-cis a subset of the other elements.[aa]bothas were reported previously but now only the secondawill be reported. I changed this because reporting bothadoesn't work with fixers.I also fixed #189 while I was at it.
The rule now covers most of the functionality of
clean-regex/optimized-character-class.