Skip to content

Conversation

@ota-meshi
Copy link
Owner

No description provided.

Copy link
Collaborator

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have really been sleep-deprived when I wrote the docs for this rule...

I left you a few suggestions to fix my mistakes but I couldn't think of a better description. The current rule description doesn't really convey what the rule is about IMO.

Also, I think we need a different name for this rule. I named no-potentially-empty-backreference because there was the no-empty-backreference rule. However, we have a no-useless-backreference rule instead. But I don't think that the name no-potentially-useless-backreference would be good either...

@ota-meshi ota-meshi changed the title Add regexp/no-potentially-empty-backreference rule Add regexp/no-potentially-useless-backreference rule Apr 16, 2021
@ota-meshi
Copy link
Owner Author

Thank you for your review!
I changed the rule name and made some changes.

I don't think the descriptions in the documentation is confusing to the user. Even if the user does not understand the description, I think that the user will understand it because there is example code.

@RunDevelopment RunDevelopment merged commit a483ecb into master Apr 16, 2021
@RunDevelopment RunDevelopment deleted the no-potentially-empty-backreference- branch April 16, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants